Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiAddressClientBuilder execution strategy control #2166

Merged
merged 64 commits into from
Jun 15, 2022
Merged

MultiAddressClientBuilder execution strategy control #2166

merged 64 commits into from
Jun 15, 2022

Commits on Mar 29, 2022

  1. MultiAddressClientBuilder execution strategy control 

    Motivation:
The `MultiAddressClientBuilder` does not currently always respect
overrides of execution strategy made by the single address
initializer
Modification:
The computed execution strategy is a combination of the multiaddress
client builder strategy, the api strategy and the client strategy.
Result:
More predictable and controllable behavior for `MultiAddressClientBuilder`
    @bondolo
    bondolo committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    dc260f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. fixes ClientEffectiveStrategyTest for basic Single and Multi builders

    @bondolo
    bondolo committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    20cec2a View commit details
    Browse the repository at this point in the history

  2. fixes ClientEffectiveStrategyTest for multi builder with initializer

    @bondolo
    bondolo committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    65ceda1 View commit details
    Browse the repository at this point in the history

  3. pre-final cleanup

    @bondolo
    bondolo committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    61814d1 View commit details
    Browse the repository at this point in the history

  4. documentation improvements

    @bondolo
    bondolo committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    09e2ea9 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Handle single address builder overrides of offloadNone()

    @bondolo
    bondolo committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    db7f892 View commit details
    Browse the repository at this point in the history

  2. checkstyle nits

    @bondolo
    bondolo committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    6392624 View commit details
    Browse the repository at this point in the history

  3. combine client api test cases

    @bondolo
    bondolo committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    24d6216 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. review feedback

    @bondolo
    bondolo committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    dd7a88d View commit details
    Browse the repository at this point in the history

  2. remove DefaultClientGroup changes from PR

    @bondolo
    bondolo committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    074584a View commit details
    Browse the repository at this point in the history

  3. test cleanup

    @bondolo
    bondolo committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    2be80b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b2dbc55 View commit details
    Browse the repository at this point in the history

  2. move FilterableClientToClient back

    @bondolo
    bondolo committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    4ade1dc View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. additional review feedback

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    b0d2c3e View commit details
    Browse the repository at this point in the history

  2. test cleanup

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    0f7c444 View commit details
    Browse the repository at this point in the history

  3. test cleanup

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    3e151d6 View commit details
    Browse the repository at this point in the history

  4. fix multi-address builder strategy computation

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    035fdd3 View commit details
    Browse the repository at this point in the history

  5. checkstyle nit

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    030833a View commit details
    Browse the repository at this point in the history

  6. more test simplification

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    5cb3a92 View commit details
    Browse the repository at this point in the history

  7. even more review feedback

    @bondolo
    bondolo committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    efba308 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e541a50 View commit details
    Browse the repository at this point in the history

  2. test improvements and suggestions from Idel's review

    @bondolo
    bondolo committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    47ec7f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. allow send offload to execute on application thread

    @bondolo
    bondolo committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    8f0819d View commit details
    Browse the repository at this point in the history

  2. allow send offload to execute on application thread

    @bondolo
    bondolo committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    330824e View commit details
    Browse the repository at this point in the history

  3. restore second request

    @bondolo
    bondolo committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    97453d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. enhance visibility in tests

    @idelpivnitskiy
    idelpivnitskiy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c7d00bd View commit details
    Browse the repository at this point in the history

  2. more debugging

    @idelpivnitskiy
    idelpivnitskiy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    522e7e6 View commit details
    Browse the repository at this point in the history

  3. more debugging 2

    @idelpivnitskiy
    idelpivnitskiy committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    36def49 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. add timestamps

    @idelpivnitskiy
    idelpivnitskiy committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    9e6530d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apple:main' into multiaddress-initializer-strategy

    @bondolo
    bondolo authored Apr 21, 2022
    Configuration menu
    Copy the full SHA
    90d1728 View commit details
    Browse the repository at this point in the history

  3. change order or ClientApi

    @idelpivnitskiy
    idelpivnitskiy committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2c7e1df View commit details
    Browse the repository at this point in the history

  4. only allow application thread if not offloading

    @bondolo
    bondolo committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5d95094 View commit details
    Browse the repository at this point in the history

  5. use local for simplification

    @bondolo
    bondolo committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    be76acf View commit details
    Browse the repository at this point in the history

  6. revert unintended changes

    @bondolo
    bondolo committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    1419244 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. capture where context map created and assigned

    @idelpivnitskiy
    idelpivnitskiy committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    60040b2 View commit details
    Browse the repository at this point in the history

  2. capture requestContext id too

    @idelpivnitskiy
    idelpivnitskiy committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    efaa5a5 View commit details
    Browse the repository at this point in the history

  3. Remove ExecutionMode.CONCURRENT

    @idelpivnitskiy
    idelpivnitskiy committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    9d6e6a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2022

  1. Revert intermediate debugging

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    ef49a05 View commit details
    Browse the repository at this point in the history

  2. Remove intermediate debug logging

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    d670415 View commit details
    Browse the repository at this point in the history

  3. reorder client api

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    a33671b View commit details
    Browse the repository at this point in the history

  4. revert ExecutionMode.CONCURRENT

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    312c836 View commit details
    Browse the repository at this point in the history

  5. small refactoring

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    34a468d View commit details
    Browse the repository at this point in the history

  6. small refactoring 2

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    3079781 View commit details
    Browse the repository at this point in the history

  7. small refactoring 3

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    f591a1c View commit details
    Browse the repository at this point in the history

  8. rename filter, add javadoc to clarify its behavior

    @idelpivnitskiy
    idelpivnitskiy committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    79b922c View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Add assertion checking for conversion reducing offloading

    @bondolo
    bondolo committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    da80a7e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. improve executionStrategy() documentation

    @bondolo
    bondolo committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    b45b45d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. improved javadoc

    @bondolo
    bondolo committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    09e63bd View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. documentation refinement for discussion

    @bondolo
    bondolo committed May 18, 2022
    Configuration menu
    Copy the full SHA
    d5a83f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    acd2535 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    dfa383b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    8380d2a View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    cead445 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    945762a View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    10da51b View commit details
    Browse the repository at this point in the history

  2. Use current strategy for merging with offloadNone()

    @bondolo
    bondolo committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7652859 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. adjust everything to current "builder takes precedece" rule

    @bondolo
    bondolo committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c52950c View commit details
    Browse the repository at this point in the history

  2. documentation matches behaviour and fix multi-offloadNone overrid

    @bondolo
    bondolo committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    aebccc9 View commit details
    Browse the repository at this point in the history

  3. fix javadoc nit

    @bondolo
    bondolo committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    55c5095 View commit details
    Browse the repository at this point in the history

  4. remove redundant modification of the request execution strategy

    @bondolo
    bondolo committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    239b3aa View commit details
    Browse the repository at this point in the history

  5. checkstyle nit

    @bondolo
    bondolo committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b6a4c15 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. remove assertion of incompatible behavior

    @bondolo
    bondolo committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    c385897 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into multiaddress-initializer-strategy

    @bondolo
    bondolo committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    81f818f View commit details
    Browse the repository at this point in the history

  3. final review feedback

    @bondolo
    bondolo committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    ee1ba16 View commit details
    Browse the repository at this point in the history