Add Publisher.replay #2684
Merged
Add Publisher.replay #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
force-pushed
the
replay_publisher
branch
3 times, most recently
from
4d5db14
to
c7dc329
Compare
Scottmitch
commented
Aug 31, 2023
| System.arraycopy(currSubs, 0, newSubs, 0, currSubs.length); | ||
| newSubs[currSubs.length] = multiSubscriber; | ||
| if (newSubscribersUpdater.compareAndSet(this, currSubs, newSubs)) { | ||
| addSubscriber(multiSubscriber); |
There was a problem hiding this comment.
note this code was moved to addSubscriber bcz replay requires that we acquire the lock before making the subscriber visible in the array (via newSubscribersUpdater) and this is preferred approach for multicast too.
|
This operator can be used to replace |
Scottmitch
force-pushed
the
replay_publisher
branch
2 times, most recently
from
fd9369c
to
cac808a
Compare
Scottmitch
force-pushed
the
replay_publisher
branch
8 times, most recently
from
dda1047
to
8d3d602
Compare
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategy.java
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategies.java
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategies.java
Outdated
Show resolved
Hide resolved
Scottmitch
force-pushed
the
replay_publisher
branch
from
8d3d602
to
0ce443b
Compare
Scottmitch
force-pushed
the
replay_publisher
branch
from
0ce443b
to
1963359
Compare
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategies.java
Outdated
Show resolved
Hide resolved
Scottmitch
force-pushed
the
replay_publisher
branch
2 times, most recently
from
d47fad3
to
3d6cc9a
Compare
Scottmitch
force-pushed
the
replay_publisher
branch
2 times, most recently
from
7f08898
to
758c2d0
Compare
Scottmitch
commented
Sep 30, 2023
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategies.java
Show resolved
Hide resolved
Scottmitch
force-pushed
the
replay_publisher
branch
from
758c2d0
to
632f2e0
Compare
Scottmitch
force-pushed
the
replay_publisher
branch
from
632f2e0
to
35e2494
Compare
Motivation: Publisher.replay provides the ability to keep state that is preserved for multiple subscribers and across resubscribes.
Scottmitch
force-pushed
the
replay_publisher
branch
from
7a7f6fe
to
b8c6237
Compare
bryce-anderson
approved these changes
Oct 2, 2023
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/ReplayStrategies.java
Outdated
Show resolved
Hide resolved
Comment on lines
162
to
177
| public void accumulate(@Nullable final T t) { | ||
| final TimeStampSignal<T> signal = new TimeStampSignal<>(executor.currentTime(NANOSECONDS), t); | ||
| for (;;) { | ||
| final int qSize = queueSize; | ||
| if (qSize < maxItems) { | ||
| if (queueSizeUpdater.compareAndSet(this, qSize, qSize + 1)) { | ||
| items.add(signal); | ||
| break; | ||
| } | ||
| } else if (queueSizeUpdater.compareAndSet(this, qSize, qSize)) { | ||
| items.poll(); | ||
| items.add(signal); | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is also an opportunity to evict stale elements if we'd like. We can have a simple private evictStale() method and call it at the start of these public methods. Then the rest looks almost exactly like MostRecentReplayAccumulator.
There was a problem hiding this comment.
lets defer this bcz LazyTimeLimitedReplayAccumulator can do the iteration and removal at the same time which is a bit harder to generalize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher.replay provides the ability to keep state that is preserved for multiple subscribers and across resubscribes.