Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concrete description for EmbeddedEventLoop #2890

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

aryan-25
Copy link
Contributor

Motivation:

We want to avoid going through EventLoopGroup's String(describing: self) when obtaining the description of an EventLoopGroup or EventLoop.

The concrete MultiThreadedEventLoopGroup and SelectableEventLoop already implement a description property. EmbeddedEventLoop does not.

Modifications:

Added a concrete description property in EmbeddedEventLoop.

Result:

The description of EmbeddedEventLoop can be obtained without going through String(describing: self).

@FranzBusch FranzBusch added the semver/patch No public API change. label Sep 19, 2024
Sources/NIOEmbedded/Embedded.swift Outdated Show resolved Hide resolved
@FranzBusch FranzBusch enabled auto-merge (squash) September 19, 2024 12:20
@FranzBusch FranzBusch merged commit 4bf92d5 into apple:main Sep 20, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants