-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Yarn Workspaces への移行 #1056
Conversation
a8bf027
to
2872192
Compare
2872192
to
22aa237
Compare
Hadolint:
|
1 similar comment
Hadolint:
|
Hadolint:
|
5108061
to
a056d95
Compare
Hadolint:
|
1 similar comment
Hadolint:
|
イメージのビルド自体は成功していますが最適化作業中, 以下の問題が存在しています. 最適化を後にする場合はこのPRをマージすることができます. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最適化はあとでいいので, コードカバレッジの CI のカバレッジファイルのパスを直しましょう. それで Approve できます
2023cba
to
cea701a
Compare
Hadolint:
|
Hadolint:
|
1 similar comment
Hadolint:
|
Codecov Report
@@ Coverage Diff @@
## main #1056 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 75 75
Lines 5195 5195
Branches 459 459
=======================================
Hits 3839 3839
Misses 898 898
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
close #998
Details of implementation (実施内容)
Yarn Workspaces に移行し, それぞれのパッケージを
@oreorebot2/bot
,@oreorebot2/docs
の2つに分割しました.@oreorebot2/docs
パッケージを含めてしまっているからだと推測されます.( Yarn Workspaces の仕様上,@oreorebot2/docs
パッケージを含めないと Docker Image のビルド時に失敗するため致し方ないと考えていますが, Docker に詳しい人が居たら指摘してくれると助かります. 私にはこれが限界です.)CONTRIBUTING.md
は別で変更したい内容があるため, 今回のPRには含めていません.