refactor: Yarn Workspaces への移行 #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0b98c7d
|
| Status: | 🚫 Build failed. |
m1sk9
force-pushed
the
yarn-workspaces
branch
5 times, most recently
from
a8bf027
to
2872192
Compare
m1sk9
force-pushed
the
yarn-workspaces
branch
from
2872192
to
22aa237
Compare
Hadolint:
|
1 similar comment
Hadolint:
|
MikuroXina
requested changes
Sep 17, 2023
Hadolint:
|
m1sk9
force-pushed
the
yarn-workspaces
branch
from
5108061
to
a056d95
Compare
Hadolint:
|
1 similar comment
Hadolint:
|
|
イメージのビルド自体は成功していますが最適化作業中, 以下の問題が存在しています.
最適化を後にする場合はこのPRをマージすることができます. |
MikuroXina
requested changes
Sep 17, 2023
MikuroXina
requested changes
Sep 17, 2023
m1sk9
force-pushed
the
yarn-workspaces
branch
from
2023cba
to
cea701a
Compare
Hadolint:
|
Hadolint:
|
1 similar comment
Hadolint:
|
Codecov Report
@@ Coverage Diff @@
## main #1056 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 75 75
Lines 5195 5195
Branches 459 459
=======================================
Hits 3839 3839
Misses 898 898
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MikuroXina
approved these changes
Sep 18, 2023
This was referenced Sep 18, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #998
Details of implementation (実施内容)
Yarn Workspaces に移行し, それぞれのパッケージを
@oreorebot2/bot,@oreorebot2/docsの2つに分割しました.@oreorebot2/docsパッケージを含めてしまっているからだと推測されます.( Yarn Workspaces の仕様上,@oreorebot2/docsパッケージを含めないと Docker Image のビルド時に失敗するため致し方ないと考えていますが, Docker に詳しい人が居たら指摘してくれると助かります. 私にはこれが限界です.)CONTRIBUTING.mdは別で変更したい内容があるため, 今回のPRには含めていません.