Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed commands during publish #24

Closed
tombruijn opened this issue Sep 24, 2021 · 0 comments · Fixed by #27
Closed

Retry failed commands during publish #24

tombruijn opened this issue Sep 24, 2021 · 0 comments · Fixed by #27
Assignees
Labels

Comments

@tombruijn
Copy link
Member

When mono runs npm/yarn publish and the OTP code is invalid (because it expired or something) the command fails and mono exits immediately. I needed to run the rest of the commands myself to finish publishing.

Instead mono should retry these commands, or prompt users if they want to retry or exit.

@tombruijn tombruijn added the bug label Sep 24, 2021
@tombruijn tombruijn self-assigned this Sep 27, 2021
tombruijn added a commit that referenced this issue Sep 28, 2021
When publishing a package and the command would fail, mono would exit
entirely. This would happen if a user would enter an invalid OTP code
during the process for example.

When in a mono package repo this could exit the entire process, such as
like on package 3 of 10. The only way to publish the package properly
then (as part was already published) is to publish them manually.

This retry option will prompt users on failure of the command to retry
it.

I've only added it to the publish command for now because that's the
only problematic one I can think of right now. If the build step fails
nothing is in a state of being half published yet. Pushing the Git
branch and tags should also be easy to do manually.

Fixes #24
tombruijn added a commit that referenced this issue Sep 28, 2021
When publishing a package and the command would fail, mono would exit
entirely. This would happen if a user would enter an invalid OTP code
during the process for example.

When in a mono package repo this could exit the entire process, such as
like on package 3 of 10. The only way to publish the package properly
then (as part was already published) is to publish them manually.

This retry option will prompt users on failure of the command to retry
it.

I've only added it to the publish command for now because that's the
only problematic one I can think of right now. If the build step fails
nothing is in a state of being half published yet. Pushing the Git
branch and tags should also be easy to do manually.

Fixes #24
tombruijn added a commit that referenced this issue Sep 28, 2021
When publishing a package and the command would fail, mono would exit
entirely. This would happen if a user would enter an invalid OTP code
during the process for example.

When in a mono package repo this could exit the entire process, such as
like on package 3 of 10. The only way to publish the package properly
then (as part was already published) is to publish them manually.

This retry option will prompt users on failure of the command to retry
it.

I've only added it to the publish command for now because that's the
only problematic one I can think of right now. If the build step fails
nothing is in a state of being half published yet. Pushing the Git
branch and tags should also be easy to do manually.

Fixes #24
tombruijn added a commit that referenced this issue Sep 28, 2021
When publishing a package and the command would fail, mono would exit
entirely. This would happen if a user would enter an invalid OTP code
during the process for example.

When in a mono package repo this could exit the entire process, such as
like on package 3 of 10. The only way to publish the package properly
then (as part was already published) is to publish them manually.

This retry option will prompt users on failure of the command to retry
it.

I've only added it to the publish command for now because that's the
only problematic one I can think of right now. If the build step fails
nothing is in a state of being half published yet. Pushing the Git
branch and tags should also be easy to do manually.

Fixes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant