Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn 3 upgrade issues #21269

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

iamakulov
Copy link
Contributor

Description

This is a follow-up to #20964 that fixes a couple surfaced issues. See commit descriptions for more details.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

  • Manual: running yarn build (ensuring the build would pass) and yarn start (ensuring the app loads correctly)

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@what-the-diff
Copy link

what-the-diff bot commented Mar 8, 2023

  • The build script was changed to use yarn workspaces
  • A type definition for the Button component was updated

@iamakulov iamakulov changed the title Yarn 3: follow-up fixes fix: yarn 3 upgrade issues Mar 8, 2023
@github-actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Mar 16, 2023
@iamakulov iamakulov removed the Stale label Mar 19, 2023
This upgrades the build script to use Yarn 3 properly. This was missed while incorporating appsmithorg#20776 into appsmithorg#20964.
Copy link
Contributor

@SatishGandham SatishGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SatishGandham SatishGandham merged commit e1dcb05 into appsmithorg:bundle-optimization Mar 21, 2023
@SatishGandham SatishGandham deleted the fix/yarn-3 branch March 21, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants