chore:update node version to v18

[KelvinOm]

Description

Update node version

[KelvinOm]

Yarn berry needs a separate plugin to check the engines versions.

yarnpkg/berry#1177

[KelvinOm]

Latest LTS version for this moment.

[ghost]

👇 Click on the image for a new way to code review

Legend

[KelvinOm]

The build with the tests is here.

[sharat87]

@KelvinOm @riodeuno, in addition to this, should we also consider changing the node-version: a.b.c lines to node-version-file: app/client/package.json instead? This will give us two things:

1. The version number is not duplicated a billion times all across the source code.
2. The NodeJS version is taken from the current branch, instead of the release branch for ok-to-test.

This is supported by code here.

I've tested in a separate test repo and it works.

What do you think?

[riodeuno]

@sharat87 Yes, I agree. @KelvinOm do you see any challenges in using this?

[KelvinOm]

@sharat87 Yes, I agree. @KelvinOm do you see any challenges in using this?

I think it's great! Checking...

[KelvinOm]

/ok-to-test

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5867116039.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 26358.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=26358&runId=5867116039_1

[sharat87]

Oh ok-to-test will still use v16, since the workflow changes to use package.json need to be in the release branch. 🙂

[KelvinOm]

The build with the tests is here. I think we can not wait for this. Since the last run was green, and here we just fixed the scripts for the node version that works.