Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add retry for JUnit failures in the CI workflow #29048

Merged
merged 2 commits into from
Nov 23, 2023
Merged

ci: Add retry for JUnit failures in the CI workflow #29048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c330de4
Add retry count
yatinappsmith Nov 23, 2023
b15706c
Added surefire report
yatinappsmith Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/server-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ jobs:
mvn --batch-mode versions:set \
-DnewVersion=${{ steps.vars.outputs.version }} \
-DgenerateBackupPoms=false \
-DprocessAllModules=true
-DprocessAllModules=true \
-Dsurefire.rerunFailingTestsCount=3 -Dsurefire.outputFile="./junit-report.xml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to do this or do we want to follow the same CI re-run that we do for Cypress where we save the failed tests in a file/db and on re-run execute just that test case. This way, we can follow the same process of reporting, skipping and/or fixing the JUnit flaky tests as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incase we decide to use caching we will be able to report rate of failure. Down side would be each rerun would have to be triggered manually. With this method retry would be automatic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do both? This is how Cypress also handles this scenario. Cypress runs a test 3 times before failing. After that, we save the failing test and on re-run, execute just the failing test.

I'm asking this because the JUnit server suite is 40 mins long. I understand that it's possible we will reduce the occurrences of flaky failures by running it 3 times before reporting a failure. But if/when there is a failure, we have to wait another 40 mins for it to pass (if at all). This is not the best utilization of our CI machine time.

Having said that, I'm open to merging this PR in & getting the CI re-run change in another PR. But I want to align on our strategy ahead.

./build.sh $args
# Restore the previous built bundle if present. If not push the newly built into the cache
Expand Down
1 change: 1 addition & 0 deletions app/server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M5</version>
<configuration>
<printSummary>true</printSummary>
<!-- Allow JUnit to access the test classes -->
<argLine>--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.time=ALL-UNNAMED
Expand Down
Loading