Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Link component, fix mobile menu #22

Merged
merged 2 commits into from
Jun 10, 2023
Merged

feat: use Link component, fix mobile menu #22

merged 2 commits into from
Jun 10, 2023

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jun 7, 2023

What does this PR do?

We are currently using <button onSubmit={() => nav('/location')} /> for navigation. This prevents users from using 'Open in a new tab', viewing the location tooltip and also makes the site less usable without javascript.

This PR migrates navigation to Qwik City's Link component which ensures SPA navigation is used with javascript but still falls back to good old anchor tags when needed.

Test Plan

Manual

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
built-with-appwrite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2023 10:40am

@loks0n loks0n requested a review from Meldiron June 7, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant