Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forceRedirect handling #728

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Add forceRedirect handling #728

merged 2 commits into from
Feb 1, 2024

Conversation

TGlide
Copy link
Contributor

@TGlide TGlide commented Jan 16, 2024

What does this PR do?

Adds redirect handling when passing in forceRedirect. Needed for init

@TGlide TGlide added the enhancement New feature or request label Jan 16, 2024
@TGlide TGlide self-assigned this Jan 16, 2024
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 3:18pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 3:18pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 3:18pm

@benmccann
Copy link
Contributor

Why remove the pnpm lockfile?

Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to use a clearer name that includes the word external, but the code looks good 👍

@TGlide
Copy link
Contributor Author

TGlide commented Jan 19, 2024

Why remove the pnpm lockfile?

Unfortunately we use npm still. We had both npm and pnpm's lockfile as a mistake.

@TorstenDittmann TorstenDittmann merged commit 58bd9fc into main Feb 1, 2024
5 checks passed
@TorstenDittmann TorstenDittmann deleted the login-redirect branch February 1, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants