Feat server side rendering #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Swinkid
reviewed
Feb 23, 2024
| const email = data.get("email") as string; | ||
| const password = data.get("password") as string; | ||
|
|
||
| const { account } = createAdminClient(); |
There was a problem hiding this comment.
@loks0n Apologies since I'm not 100% on Astro, but wouldn't this be insecure using the admin client on a front-end page (Exposing the appwrite key..?) ? You'd need to use sdk-for-web, create a client for that and call that sign in.
There was a problem hiding this comment.
Code inside --- runs on the server.
See https://docs.astro.build/en/basics/astro-components/#the-component-script
There was a problem hiding this comment.
Code inside
---runs on the server.See https://docs.astro.build/en/basics/astro-components/#the-component-script
Cool, thanks for clarifying. Only just started looking at Astro!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.