Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #108

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Dev #108

merged 3 commits into from
Feb 14, 2024

Conversation

christyjacob4
Copy link
Member

What does this PR do?

Bug fixes and improvements

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, looks like we added a lot of redundant new lines in the service methods as well

Comment on lines -10 to +9
static CHUNK_SIZE = 5*1024*1024; // 5MB
CHUNK_SIZE = 5*1024*1024; // 5MB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be an instance var?

Comment on lines +130 to +131
graphqlQuery,
graphqlMutation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tabs at EOL

@christyjacob4 christyjacob4 merged commit b72ade6 into master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants