Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better multipart tests #989

Merged
merged 54 commits into from
Oct 1, 2024
Merged

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Sep 26, 2024

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@@ -2,7 +2,7 @@ services:
mockapi:
container_name: mockapi
ports:
- 8080:80
- 3175:80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying, 8080 conflicts with appwrite/appwrite

tests/Base.php Outdated Show resolved Hide resolved
tests/resources/spec.json Outdated Show resolved Hide resolved
@loks0n loks0n mentioned this pull request Oct 1, 2024
@loks0n loks0n merged commit b2ffda2 into feat-multipart Oct 1, 2024
27 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants