Enforce types in AdapterPluginEvents.onNetworkChange #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
reviewed
Jul 11, 2023
|
please update changelog so we can publish a new version once this PR lands |
BriungRi
force-pushed
the
bl/plugin-provider
branch
from
3b501d7
to
7d9291b
Compare
0xmaayan
reviewed
Jul 11, 2023
BriungRi
force-pushed
the
bl/plugin-provider
branch
from
157e9b7
to
652d821
Compare
0xmaayan
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforce types based on the way
WalletCorecallsonNetworkChange. This diff depends on a PR in petra-plugin-wallet-adapter for the wallet to conform to the new type.