Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add deno #2479

Merged
merged 2 commits into from
Mar 11, 2022
Merged

feat: Add deno #2479

merged 2 commits into from
Mar 11, 2022

Conversation

4513ECHO
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Mar 11, 2022
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Mar 11, 2022
Closed
@suzuki-shunsuke suzuki-shunsuke added this to the v1.8.0 milestone Mar 11, 2022
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution.

@suzuki-shunsuke
Copy link
Member

I'm not familiar with Deno, so I'm investigating whether Deno can be supported by aqua properly.
I added Node.js to the registry once, but I reverted it because Node.js couldn't be supported by aqua.
I'd like to avoid the same mistake. #1436

Deno ships as a single executable with no dependencies, and doesn't have a package manager like npm.
deno install installs executable files in the following paths, which don't depend on Deno's install path.

  - --root option
  - DENO_INSTALL_ROOT environment variable
  - $HOME/.deno

It seems that Deno can be supported by aqua.

@4513ECHO
Copy link
Contributor Author

Yes. I am managing Deno by aqua, and deno install works correctly on my envrironment.

suzuki-shunsuke
suzuki-shunsuke reviewed Mar 11, 2022
View reviewed changes
registry.yaml Outdated Show resolved Hide resolved
@suzuki-shunsuke suzuki-shunsuke self-requested a review March 11, 2022 08:33
@suzuki-shunsuke suzuki-shunsuke merged commit 2232967 into aquaproj:main Mar 11, 2022
@suzuki-shunsuke
Copy link
Member

Released v1.8.0 🚀

@4513ECHO 4513ECHO deleted the feat/deno branch March 11, 2022 09:28
@suzuki-shunsuke suzuki-shunsuke linked an issue Mar 12, 2022 that may be closed by this pull request
Add deno #963
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-shunsuke suzuki-shunsuke suzuki-shunsuke approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Add deno
2 participants
@4513ECHO @suzuki-shunsuke