Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build workflow split #1025

Merged
merged 5 commits into from
Oct 28, 2021
Merged

Build workflow split #1025

merged 5 commits into from
Oct 28, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 16, 2021

Split the build workflow in different part with a different range of responsibilities for each one: linting, unit tests, e2e tests and release of the snapshot so if one of them fails its easily identified. It also decrease the time required for the build as some task are parallelized.

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1025 (8afe7d5) into main (765b2d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files          14       14           
  Lines        1905     1905           
=======================================
  Hits         1211     1211           
  Misses        633      633           
  Partials       61       61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765b2d1...8afe7d5. Read the comment docs.

@mmorel-35 mmorel-35 changed the title Build workfow split Build workflow split Oct 16, 2021
@yoavrotems yoavrotems self-requested a review October 20, 2021 09:20
Copy link
Contributor

@yoavrotems yoavrotems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, very nice that is save building time 🕐

@yoavrotems yoavrotems merged commit dd68e85 into aquasecurity:main Oct 28, 2021
@mmorel-35 mmorel-35 deleted the patch-1 branch October 28, 2021 10:13
tengqm pushed a commit to tengqm/kube-bench that referenced this pull request Aug 24, 2022
* Separate yaml lint from build

* Separate e2e tests, unit tests and snapshot release

* Update build.yml

Co-authored-by: Yoav Rotem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants