New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubectl to check the kubernetes version #34

Merged

lizrice merged 1 commit into master from kubectl-version

Aug 11, 2017

Contributor

lizrice commented Aug 11, 2017

Fixes #15


          Use kubectl to check the kubernetes version

96c4696

lizrice merged commit 45cf25e into master

lizrice deleted the kubectl-version branch

August 11, 2017 17:05

lizrice mentioned this pull request

Misleading warning message if version check is skipped #20

Closed

ttousai reviewed

View reviewed changes

cmd/util.go

    
              	if err != nil {

              		continueWithError(err, sprintlnWarn("Kubernetes version check skipped"))

              		return

              	}

              	cmd := exec.Command(b, "--version")

              	cmd := exec.Command("kubectl", "version")

              	out, err := cmd.Output()

Contributor

ttousai Aug 19, 2017

@lizrice Can we make kubectl version command's output only be printed when log level is set to 1? I think it clutters the output of kube-bench.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet