Modified Decode() to use SplitN rather than Split

[jessequinn]

Modified Decode() in docker config pkg to use SplitN rather than Split. This allows GCR auths to be split that contain multiple : characters.

Description

Related issues

• Close Support Service Account Keys defined in ImagePullSecrets #857

Checklist

• I've read the guidelines for contributing to this repository.
• I've added tests that prove my fix is effective or that my feature works.

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #1126 (f74a5a3) into main (1550730) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   57.96%   57.95%   -0.02%     
==========================================
  Files          71       71              
  Lines        9305     9305              
==========================================
- Hits         5394     5393       -1     
- Misses       3361     3362       +1     
  Partials      550      550              

Impacted Files	Coverage Δ
pkg/docker/config.go	73.61% <100.00%> (ø)
pkg/operator/controller/ciskubebenchreport.go	50.99% <0.00%> (-1.60%)	⬇️
pkg/vulnerabilityreport/controller.go	54.57% <0.00%> (-1.22%)	⬇️
pkg/cmd/installer.go	43.00% <0.00%> (-0.35%)	⬇️
pkg/configauditreport/controller.go	62.46% <0.00%> (+0.92%)	⬆️
pkg/operator/controller/configauditreport.go	54.03% <0.00%> (+1.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1550730...f74a5a3. Read the comment docs.

[chen-keinan]

@jessequinn were you able to build the image and load it to kind?

[jessequinn]

@jessequinn were you able to build the image and load it to kind?

yes. however, the image will not contain this change. building the image uses github directly from what i remember.

[chen-keinan]

@jessequinn were you able to build the image and load it to kind?

yes. however, the image will not contain this change. building the image uses github directly from what i remember.

make docker-build will build it locally and create the this image:aquasec/starboard-operator:dev

Is this what you used?

[jessequinn]

@jessequinn were you able to build the image and load it to kind?

yes. however, the image will not contain this change. building the image uses github directly from what i remember.

make docker-build will build it locally and create the this image:aquasec/starboard-operator:dev

Is this what you used?

yes. verbatim to the contribution info page.

[chen-keinan]

I see, it should work. I'll check it myself now

[jessequinn]

considering the change is so small why would it not work?

[chen-keinan]

considering the change is so small, why would it not work?

I agree it should be ok, will do a quick check.

[chen-keinan]

LGTM!, thank you for the contribution, please rebase your branch with upstream