fix: panic when image pull secret cannot be parsed #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate which secret cannot be parsed and why:
error: reading .dockerconfigjson field of "default/regcred" secret:
expected username and password concatenated with a colon (:)
Resolves: #751
Signed-off-by: Daniel Pacak <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 65.53% 65.59% +0.06%
==========================================
Files 58 58
Lines 6305 6308 +3
==========================================
+ Hits 4132 4138 +6
+ Misses 1759 1757 -2
+ Partials 414 413 -1
Continue to review full report at Codecov.
|
deven0t
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicate which secret cannot be parsed and why:
Resolves: #751
Signed-off-by: Daniel Pacak [email protected]