Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(checks): Rename repo to trivy-checks #109

Merged
merged 9 commits into from
Apr 17, 2024
Merged

chore(checks): Rename repo to trivy-checks #109

merged 9 commits into from
Apr 17, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Apr 9, 2024

run: |
tags=(latest ${{ env.RELEASE_VERSION}} ${{env.MINOR_VERSION }} ${{ env.MAJOR_VERSION }})
for tag in ${tags[@]}; do
oras push ghcr.io/aquasecurity/trivy-policies:${tag} \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this hardcoded for trivy-policies bundle as we will also rename the repo (to trivy-checks) but want to keep the bundle for backwards compatibility.

@simar7
Copy link
Member Author

simar7 commented Apr 9, 2024

@nikpivkin could you take a look? The PR itself is minor but please feel to point if if we've missed any other part of the repo (or elsewhere) that needs to be renamed.

@simar7 simar7 changed the title chore(checks): Rename policy bundle to checks bundle chore(checks): Rename repo to trivy-checks Apr 9, 2024
@simar7
Copy link
Member Author

simar7 commented Apr 9, 2024

I've verified the generation of the checks bundle here https://github.com/aquasecurity/trivy-checks/pkgs/container/trivy-checks

@@ -4,7 +4,7 @@ Use the most modern TLS/SSL policies available
```hcl
resource "aws_cloudfront_distribution" "good_example" {
viewer_certificate {
cloudfront_default_certificate = false
cloudfront_default_certificate = aws_acm_certificate.example.arn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to synchronize with the main branch.

@nikpivkin
Copy link
Contributor

@simar7 Trivy has successfully downloaded the new bundle. There is still some use of the term policies in code, but mostly in tests. Should this be changed too, or is it not critical?

@simar7
Copy link
Member Author

simar7 commented Apr 11, 2024

@simar7 Trivy has successfully downloaded the new bundle. There is still some use of the term policies in code, but mostly in tests. Should this be changed too, or is it not critical?

Yeah I thought to just leave it for now.

@simar7 simar7 requested a review from nikpivkin April 13, 2024 05:59
@@ -1,15 +1,13 @@

Using Customer managed keys provides comprehensive control over cryptographic keys, enabling management of policies, permissions, and rotation, thus enhancing security and compliance measures for sensitive data and systems.
Cloudtrail logs should be encrypted at rest to secure the sensitive data. Cloudtrail logs record all activity that occurs in the the account through API calls and would be one of the first places to look when reacting to a breach.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you synchronise this and other files?

@simar7 simar7 requested a review from nikpivkin April 17, 2024 03:54
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simar7 simar7 merged commit d673b86 into main Apr 17, 2024
5 checks passed
@simar7 simar7 deleted the check-bundle branch April 17, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(misconf): Simplify nomenclature for misconfig checks
2 participants