Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: init separate package for bundle scripts #218

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 20, 2024

The docker and test-containers packages are only used for bundle verification. Сreating a separate package for scripts reduce the dependency resolution chore when updating Trivy and reduce dependabot noise.

@nikpivkin nikpivkin marked this pull request as ready for review August 20, 2024 06:20
@nikpivkin nikpivkin requested a review from simar7 as a code owner August 20, 2024 06:20
@@ -0,0 +1,60 @@
module github.com/aquasecurity/trivy-checks/bundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this file (and also the go.sum) have git addition marks? (The plus sign appended to each of the lines).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a new file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh 🤦🏼 you're right!

@simar7 simar7 self-requested a review August 21, 2024 04:59
@simar7 simar7 added this pull request to the merge queue Aug 21, 2024
Merged via the queue into aquasecurity:main with commit 020ecf4 Aug 21, 2024
5 checks passed
@nikpivkin nikpivkin deleted the bundle-pkg branch August 21, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants