Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(checks): deprecate some checks #245

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 27, 2024

  1. AVD-AWS-0134. This check uses a mechanism of custom checks, which are passed terraform blocks directly rather than general state. Because of this, this check cannot be ported to Rego.
  2. AVD-AWS-0175 and AVD-AWS-0169. These checks are triggered when there are no resources. The problem is that Trivy does not export empty structures for Rego. Because of this, filtering with selectors does not work and the check is not applied. If you remove the selectors, the check will always work, even when not scanning AWS. These checks are better evaluated in other ways as these resources can be configured in other ways.

@simar7 simar7 marked this pull request as ready for review August 28, 2024 19:24
@simar7 simar7 self-requested a review as a code owner August 28, 2024 19:24
@simar7 simar7 merged commit fb12f73 into aquasecurity:main Aug 28, 2024
4 of 5 checks passed
@nikpivkin nikpivkin deleted the dep-checks branch August 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants