Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): Use trivy pkgs instead of defsec #77

Closed
wants to merge 4 commits into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Feb 12, 2024

No description provided.

@simar7
Copy link
Member Author

simar7 commented Feb 13, 2024

Update when aquasecurity/trivy#6109 is merged

@simar7 simar7 marked this pull request as ready for review February 17, 2024 00:34
@simar7
Copy link
Member Author

simar7 commented Feb 17, 2024

@nikpivkin could you take a look at reviewing this?

"github.com/aquasecurity/trivy/pkg/iac/scan"
"github.com/aquasecurity/trivy/pkg/iac/severity"
"github.com/aquasecurity/trivy/pkg/iac/state"
defsecTypes "github.com/aquasecurity/trivy/pkg/iac/types"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think defsecTypes could be renamed trivyTypes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will apply this suggestion in this PR #80 thanks.

@simar7
Copy link
Member Author

simar7 commented Feb 21, 2024

Sorry @nikpivkin I superseded this PR with #80 - that one also includes the use of trivy packages as it was required to do that with the cmd/ binaries.

@simar7 simar7 closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants