Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secret): find aws secrets ending with a comma or dot #5921

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(secret): find aws secrets ending with a comma or dot #5921

merged 1 commit into from
Jan 11, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

See #5920

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jan 11, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review January 11, 2024 07:54
@knqyf263 knqyf263 added this pull request to the merge queue Jan 11, 2024
Merged via the queue into aquasecurity:main with commit ae134a9 Jan 11, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/secret-aws-comma branch January 11, 2024 08:37
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(secret): detect AWS secrets in image config
2 participants
@DmitriyLewen @knqyf263