Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update band logos #5968

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

AnaisUrlichs
Copy link
Contributor

No description provided.

@simar7
Copy link
Member

simar7 commented Jan 18, 2024

Are new t-shirts part of the code review as well? 🆕

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logo should be smaller to reduce the image size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will update it

@AnaisUrlichs AnaisUrlichs changed the title Update logos Style: Update band logos Jan 19, 2024
Signed-off-by: AnaisUrlichs <[email protected]>
@AnaisUrlichs AnaisUrlichs changed the title Style: Update band logos style: update band logos Jan 19, 2024
Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one nit is that file names still say "2022".

@knqyf263
Copy link
Collaborator

@itaysk Do we want to keep the year in the file names? Can we remove the year like brand/Trivy-OSS-Logo-Color-Horizontal-RGB.png?

@AnaisUrlichs
Copy link
Contributor Author

@knqyf263 @itaysk I wasn't sure if the file names are used anywhere -- I meant to ask you as I could not find them in the trivy repo being used -- otherwise, I would just remove the year name?

@itaysk
Copy link
Contributor

itaysk commented Jan 22, 2024

yes removing the year sounds good

@knqyf263 knqyf263 added this pull request to the merge queue Jan 23, 2024
Merged via the queue into aquasecurity:main with commit bb6caea Jan 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants