-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: update band logos #5968
style: update band logos #5968
Conversation
Signed-off-by: AnaisUrlichs <[email protected]>
Signed-off-by: AnaisUrlichs <[email protected]>
Are new t-shirts part of the code review as well? 🆕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title must comply with the policy.
https://aquasecurity.github.io/trivy/v0.48/community/contribute/pr/#title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logo should be smaller to reduce the image size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will update it
Signed-off-by: AnaisUrlichs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. one nit is that file names still say "2022".
@itaysk Do we want to keep the year in the file names? Can we remove the year like |
yes removing the year sounds good |
Signed-off-by: AnaisUrlichs <[email protected]>
No description provided.