Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): Include licenses and secrets filtered by rego to ModifiedFindings #6483

Conversation

kristyko
Copy link
Contributor

Description

In #6004 rego policy was extended to allow filtering Licenses and Filters, but I somehow overlooked that there’s ModifiedFindings available now, so with this PR I’m trying to fix this and include them, just like it currently includes misconfigurations and vulnerabilities. I’ve updated tests accordingly, and also made them reuse predefined license and secret examples.

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@kristyko kristyko requested a review from knqyf263 as a code owner April 11, 2024 15:15
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knqyf263 knqyf263 added this pull request to the merge queue May 14, 2024
Merged via the queue into aquasecurity:main with commit fa3cf99 May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants