Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): do not use semver for parsing tf module versions #6614

Merged
merged 1 commit into from
May 4, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

Terraform does not use semantic module versioning, so we must use the github.com/aquasecurity/go-version/pkg/version package to parsing module versions.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review May 3, 2024 04:53
@nikpivkin nikpivkin requested a review from simar7 as a code owner May 3, 2024 04:53
@nikpivkin
Copy link
Contributor Author

@simar7 I haven't noticed any problems with the github.com/aquasecurity/go-version/pkg/version package. Or should we use the github.com/hashicorp/go-version package to handle module versions like terraform does?

@knqyf263
Copy link
Collaborator

knqyf263 commented May 3, 2024

I implemented github.com/aquasecurity/go-version based on github.com/hashicorp/go-version with more support on specifiers (a.k.a version range). Version parsing should work in the same way.

@simar7 simar7 added this pull request to the merge queue May 4, 2024
Merged via the queue into aquasecurity:main with commit 9c794c0 May 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(misconf) Terraform module: "Failed to load module "improper constraint:"
3 participants