Remove OrderedHash #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aquasync, any chance you could take a look at this pull request? |
|
Hi @mvz, I'm all for deleting unnecessary code, but at least for the time being 1.8 (old as it may be) is actually the version the library was built using and I've never really got round to making sure it supports 1.9+ properly. One of these days I'll get around to it but time has been hard to come by. Would be fine with a conditional that only falls back to OrderedHash for RUBY_VERSION < 1.9 though. |
I'm sure it works fine on newer Rubies. I can add an explicit dependency on 1.9+ to the gemfile to avoid problems for any users of 1.8. |
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby's hashes have been ordered since 1.9.1, so there's no need to have a separate OrderedHash implementation anymore.