Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code signing #13

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Add code signing #13

merged 4 commits into from
Jun 8, 2021

Conversation

arafaysaleem
Copy link
Owner

This PR adds code signing config and improvements to the release workflow for signed APK

@github-actions github-actions bot added chores Changes that does not modify source or test files CI/CD Improvements or additions to the workflows labels Jun 8, 2021
Copy link
Owner Author

@arafaysaleem arafaysaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've identified a missing key in google drive job

Copy link
Owner Author

@arafaysaleem arafaysaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Owner Author

@arafaysaleem arafaysaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make fixes

This improves the speed of the Test PR workflow and doesn't require signing config keys

Signed-off-by: arafaysaleem <[email protected]>
Copy link
Owner Author

@arafaysaleem arafaysaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now

@arafaysaleem arafaysaleem merged commit 382232d into dev Jun 8, 2021
@arafaysaleem arafaysaleem deleted the ci/fix-release-workflow branch June 8, 2021 17:46
arafaysaleem added a commit that referenced this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chores Changes that does not modify source or test files CI/CD Improvements or additions to the workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant