Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some animations and performance on some screens. #3

Merged
merged 8 commits into from
Jun 7, 2021
Merged

Improve some animations and performance on some screens. #3

merged 8 commits into from
Jun 7, 2021

Conversation

arafaysaleem
Copy link
Owner

This PR improves loading time of theater screen by caching the responses.
It also disable CI workflows running twice.
Finally, it adds some nice animations to movie details screen.

@arafaysaleem
refact(Provider): locally store loaded theaters
7750b1a 
Signed-off-by: arafaysaleem <[email protected]>
@arafaysaleem
CI(Actions): Disable PR test from running on dev push
0f8501a 
Signed-off-by: arafaysaleem <[email protected]>
@arafaysaleem
ci(Actions): Rename status check to signify test
3964b65 
Signed-off-by: arafaysaleem <[email protected]>
@arafaysaleem
refact(Provider): Allow fetching theater from cache
6bfced9 
Theaters rarely change and therefore should be stored and returned from a local list

Signed-off-by: arafaysaleem <[email protected]>
@arafaysaleem
enhance(Widget): Make movie poster tappable in carousel
cfa2532 
Signed-off-by: arafaysaleem <[email protected]>
@arafaysaleem
feat(Widgets): Animate movie posters on details screen
de5f961 
Signed-off-by: arafaysaleem <[email protected]>
@arafaysaleem
Merge branch 'feature/animate-movie-details-posters' into dev
3050818
@arafaysaleem
chore(Providers): fix suppressed lint errors
19d2770 
Lints suppressed earlier to avoid analyzer alarms can be completely fixed now

Signed-off-by: arafaysaleem <[email protected]>
@github-actions github-actions bot added CI/CD Improvements or additions to the workflows providers Changes concerning state-management or dependency injection views Changes to visual elements screens Improvements or additions to screens widgets Improvements or additions to widgets presentation-layer Changes concerning UI labels Jun 7, 2021
@arafaysaleem arafaysaleem added the enhancement Improvement request to an existing feature label Jun 7, 2021
arafaysaleem
arafaysaleem commented Jun 7, 2021
View reviewed changes
Copy link
Owner Author

@arafaysaleem arafaysaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arafaysaleem arafaysaleem merged commit 739aee5 into master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD Improvements or additions to the workflows enhancement Improvement request to an existing feature presentation-layer Changes concerning UI providers Changes concerning state-management or dependency injection screens Improvements or additions to screens views Changes to visual elements widgets Improvements or additions to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arafaysaleem