Dev 17/08/2021 #77
Merged
Dev 17/08/2021 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #70 from arafaysaleem/dev
* chore(Assets): add offline google fonts Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden test for home screen Signed-off-by: arafaysaleem <[email protected]> * test(Screens): refactor golden test for home screen Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden test for login screen Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): add a global golden test config Signed-off-by: arafaysaleem <[email protected]> * chore(Gitignore): ignore windows generated golden pngs Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): add shared mocks for auth provider Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden tests for register screen Signed-off-by: arafaysaleem <[email protected]> * test(Screens): refactor golden tests for home and login screens Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): add a workflow to update goldens for new changes Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): update PR actions to new versions Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add comments to all golden tests Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): fix test folder path for ubuntu file system Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): generate local goldens in different dir Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): add a comment to common_mocked_providers.dart Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): update generated goldens for new changes * ci(Goldens): restrict generation to only if dart code updates Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden tests for change password screen Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): update generated goldens for new changes Co-authored-by: arafaysaleem <[email protected]>
* wip(Screen): Add a forgot password screen Signed-off-by: arafaysaleem <[email protected]> * refact(Typedef/Screens): add new typedefs for provider listeners Signed-off-by: arafaysaleem <[email protected]> * refact(Typedef/Screens): add new typedefs for provider listeners Signed-off-by: arafaysaleem <[email protected]> chore(Lint): prefer relative imports Signed-off-by: arafaysaleem <[email protected]> * refact(Screen): Refactor the forgot password screen Signed-off-by: arafaysaleem <[email protected]> * refact(AuthProvider): update provider state in forget password functions Signed-off-by: arafaysaleem <[email protected]> * refact(Screen): add routing to forget password screen Signed-off-by: arafaysaleem <[email protected]> * refact(Screen): rename forget password widgets to use forget Signed-off-by: arafaysaleem <[email protected]> * chore(Pubspec): update dependencies Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): update generated goldens for new changes * refact(Helper): Change otp digit error message to single letter Signed-off-by: arafaysaleem <[email protected]> * refact(Models): remove unnecessary json annotation, disable error warning Signed-off-by: arafaysaleem <[email protected]> * refact(Providers): seperate forgot pw logic into it's own provider Signed-off-by: arafaysaleem <[email protected]> * add(Widgets): add callbacks to custom dialog buttons Signed-off-by: arafaysaleem <[email protected]> * add(Widgets): introduce padding property on rounded bottom container Signed-off-by: arafaysaleem <[email protected]> * refact(Screens/Widgets): fix visuals and bugs with forgot password workflow Signed-off-by: arafaysaleem <[email protected]> * refact(Provider): change loading message for reset password state Signed-off-by: arafaysaleem <[email protected]> * refact(Screen): pop screen after change password succesful Signed-off-by: arafaysaleem <[email protected]> * refact(Widget): change otp inputs' height and validation Signed-off-by: arafaysaleem <[email protected]> * refact(Widget): add pop confirmation on reset password form Signed-off-by: arafaysaleem <[email protected]> * add(Provider/Widget): add method to resend otp code Signed-off-by: arafaysaleem <[email protected]> * ci(Goldens): run golden generation on changes to views directory Signed-off-by: arafaysaleem <[email protected]> * refact(Screen): change password reset failure popup title Signed-off-by: arafaysaleem <[email protected]> * ci(Goldens): change name of golden generation job Signed-off-by: arafaysaleem <[email protected]> * refact(Widgets): use null aware operators instead of if checks Signed-off-by: arafaysaleem <[email protected]> Co-authored-by: arafaysaleem <[email protected]>
* chore(Assets): add offline google fonts Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden test for home screen Signed-off-by: arafaysaleem <[email protected]> * test(Screens): refactor golden test for home screen Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden test for login screen Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): add a global golden test config Signed-off-by: arafaysaleem <[email protected]> * chore(Gitignore): ignore windows generated golden pngs Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): add shared mocks for auth provider Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden tests for register screen Signed-off-by: arafaysaleem <[email protected]> * test(Screens): refactor golden tests for home and login screens Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): add a workflow to update goldens for new changes Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): update PR actions to new versions Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add comments to all golden tests Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): fix test folder path for ubuntu file system Signed-off-by: arafaysaleem <[email protected]> * ci(Actions): generate local goldens in different dir Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): add a comment to common_mocked_providers.dart Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): update generated goldens for new changes * ci(Goldens): restrict generation to only if dart code updates Signed-off-by: arafaysaleem <[email protected]> * test(Screens): add golden tests for change password screen Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): update generated goldens for new changes * test(Goldens): add golden tests for forgot password screen Signed-off-by: arafaysaleem <[email protected]> * test(Utils): add unit test for new form validator methods Signed-off-by: arafaysaleem <[email protected]> * test(Extensions): add unit tests for new otp extension Signed-off-by: arafaysaleem <[email protected]> * test(Goldens): update generated goldens for new changes * ci(Goldens): don't run on view changes. Might generate incorrect UIs Signed-off-by: arafaysaleem <[email protected]> Co-authored-by: arafaysaleem <[email protected]>
… auto_route * add(Routes): add a routes class with screen names Signed-off-by: arafaysaleem <[email protected]> * add(Router): add a router utility for easier navigation Signed-off-by: arafaysaleem <[email protected]> * chore(Dependency): remove auto_route package dependency Signed-off-by: arafaysaleem <[email protected]> * refact: replace auto router with our AppRouter and Routes class Signed-off-by: arafaysaleem <[email protected]> * refact(Router): change Object? to dynamic in MaterialPageRoute Signed-off-by: arafaysaleem <[email protected]> * refact(Widget): increase animation duration of floating movie posters Signed-off-by: arafaysaleem <[email protected]> * refact(Provider): remove otp int parsing in forgot password provider Signed-off-by: arafaysaleem <[email protected]> * ci(Test-PR): remove routes file from test coverage Signed-off-by: arafaysaleem <[email protected]>
github-actions
bot
added
analyzer
CI/CD
Codecov Report
@@ Coverage Diff @@
## release #77 +/- ##
============================================
+ Coverage 7.83% 22.08% +14.24%
============================================
Files 124 134 +10
Lines 2769 3084 +315
============================================
+ Hits 217 681 +464
+ Misses 2552 2403 -149
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.