Skip to content

Commit

Permalink
ACL: Fix inline doc and functions indentation (#579)
Browse files Browse the repository at this point in the history
  • Loading branch information
facuspagnuolo authored May 29, 2020
1 parent d911a8b commit 8d40fea
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions contracts/acl/ACL.sol
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ contract ACL is IACL, TimeHelpers, AragonApp, ACLHelpers {
uint8 internal constant ORACLE_PARAM_ID = 203;
uint8 internal constant LOGIC_OP_PARAM_ID = 204;
uint8 internal constant PARAM_VALUE_PARAM_ID = 205;
// TODO: Add execution times param type?

/* Hardcoded constant to save gas
bytes32 public constant EMPTY_PARAM_HASH = keccak256(uint256(0));
Expand Down Expand Up @@ -233,10 +232,10 @@ contract ACL is IACL, TimeHelpers, AragonApp, ACLHelpers {
}

/**
* @dev Function called by apps to check ACL on kernel or to check permission statu
* @dev Function called by apps to check ACL on kernel or to check permission status
* @param _who Sender of the original call
* @param _where Address of the app
* @param _where Identifier for a group of actions in app
* @param _what Identifier for a group of actions in app (role)
* @param _how Permission parameters
* @return boolean indicating whether the ACL allows the role or not
*/
Expand Down Expand Up @@ -269,7 +268,10 @@ contract ACL is IACL, TimeHelpers, AragonApp, ACLHelpers {
address _where,
bytes32 _what,
uint256[] _how
) public view returns (bool)
)
public
view
returns (bool)
{
if (_paramsHash == EMPTY_PARAM_HASH) {
return true;
Expand Down Expand Up @@ -322,7 +324,10 @@ contract ACL is IACL, TimeHelpers, AragonApp, ACLHelpers {
address _where,
bytes32 _what,
uint256[] _how
) internal view returns (bool)
)
internal
view
returns (bool)
{
if (_paramId >= permissionParams[_paramsHash].length) {
return false; // out of bounds
Expand Down

0 comments on commit 8d40fea

Please sign in to comment.