Testing improvements #513
Merged
Testing improvements #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,9 @@ const processResult = txReceipt => { | |||
| throw new Error(log.args.message) | |||
| } | |||
| }) | |||
| if (mustAssert && !decodedLogs.length) { | |||
| throw new Error('No assertions made') | |||
| } | |||
There was a problem hiding this comment.
Don't know if this is necessary, test fwks usually don't throw if there are no assertions, they simply throw in case there was at least one failure.
There was a problem hiding this comment.
Yes... it is kind of "special" behaviour but for our purposes I think having this check is more robust:
- Tests without explicit assertions made are probably buggy in some way
- This implicitly tests that the test framework is working (decoding
Assert's events), avoiding an earlier issue where the tests were always just passing regardless of actual test behaviour.
facuspagnuolo
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some improvements to the test suite, as per the Consensys Diligence advisory.