Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disputable: Add tests to check role constants #605

Merged
merged 2 commits into from
Aug 1, 2020
Merged

Disputable: Add tests to check role constants #605

merged 2 commits into from
Aug 1, 2020

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Jul 31, 2020

No description provided.

@bingen bingen self-assigned this Jul 31, 2020
@coveralls
Copy link

coveralls commented Jul 31, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 98.505% when pulling fc35c9a on disputable_test_roles into 7436b47 on next.

sohkai
sohkai approved these changes Jul 31, 2020
View reviewed changes
test/contracts/apps/disputable/disputable_app.js Outdated
@@ -1,3 +1,4 @@
const { keccak_256 } = require('js-sha3')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, let's use web3-utils' version instead!

@facuspagnuolo facuspagnuolo changed the title disputable: Add tests to check role constants Disputable: Add tests to check role constants Aug 1, 2020
facuspagnuolo
facuspagnuolo approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I went ahead and push come polishing

@facuspagnuolo facuspagnuolo merged commit 84f1c0d into next Aug 1, 2020
@facuspagnuolo facuspagnuolo deleted the disputable_test_roles branch August 1, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facuspagnuolo facuspagnuolo facuspagnuolo approved these changes

@sohkai sohkai sohkai approved these changes

Assignees

@bingen bingen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bingen @coveralls @sohkai @facuspagnuolo