Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: Improvement round #1 #233

Merged
merged 17 commits into from
Dec 3, 2020
Merged

Console: Improvement round #1 #233

merged 17 commits into from
Dec 3, 2020

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Nov 23, 2020

Implements all changes seen in Delphi Digital's demo, and in #229, namely:

  • Highlights DAO Name and makes it bigger
  • On the top area, includes general info from Contraktor (Token balances, latest activity, links to Etherscan transactions).
  • Adds token name, ticker, and symbol (if possible) with link to the token contract on Etherscan
  • Action card information: include the action status
  • Add actions pagination (8 / 12 cards per page)
  • Move “New action” button to the top of the section
  • Add filters / different views for: “Enqueued” & “Executed” actions
  • Display info in a table format including categories following the previous client designs
  • Filter out the available actions buttons based on the action status (e.i.: if action status is executed, do not show the “Execute” button)

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #233 (4d646c5) into master (d6bf24f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   51.36%   51.36%           
=======================================
  Files          31       31           
  Lines         512      512           
  Branches       60       60           
=======================================
  Hits          263      263           
  Misses        249      249           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6bf24f...4d646c5. Read the comment docs.

@Evalir Evalir changed the title Console: improvements for demo [WIP] Console: improvements for demo Dec 3, 2020
@Evalir Evalir changed the title [WIP] Console: improvements for demo Console: Improvement round #1 Dec 3, 2020
While it would be great to update to the latest version of React and all
its tooling, there seems to be an issue with typescript versions,
react-scripts and the new JSX transform wreaking havoc on the JSX
checks. While the issue was supposedly fixed here
(facebook/create-react-app#9869), upgrading to
react-scripts 4.0.1 doesn't fix the problem. Neither does upgrading AND
pinning typescript to 4.0.5 so it doesn't overwrite the tsconfig.json
file. Let's wait a few versions ahead for react-scripts so we can be
sure this is fixed.
@Evalir Evalir merged commit 3e76493 into master Dec 3, 2020
@Evalir Evalir deleted the demo-1 branch December 3, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants