Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1/64 problem in DAO executor #333

Merged
merged 9 commits into from
Mar 24, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Mar 16, 2023

Description

Code4rena Finding: code-423n4/2023-03-aragon-findings#191

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik force-pushed the feature/fix-issue-191-gasleft-dao-executor branch from bd43edf to 5d39a11 Compare March 22, 2023 09:22
@heueristik heueristik force-pushed the feature/fix-issue-191-gasleft-dao-executor branch from 29db017 to 2cf4e90 Compare March 22, 2023 14:36
@heueristik heueristik marked this pull request as ready for review March 22, 2023 14:43
packages/contracts/src/core/dao/DAO.sol Outdated Show resolved Hide resolved
packages/contracts/test/core/dao/dao.ts Outdated Show resolved Hide resolved
@mathewmeconry mathewmeconry mentioned this pull request Mar 24, 2023
12 tasks
@mathewmeconry mathewmeconry merged commit fa58f72 into develop Mar 24, 2023
@mathewmeconry mathewmeconry deleted the feature/fix-issue-191-gasleft-dao-executor branch March 24, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants