Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder setups and Multisig Build 2 deployment #336

Merged
merged 33 commits into from
Mar 24, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Mar 22, 2023

Description

This PR adds a PlaceholderSetup that we can use to populate plugin repos with earlier versions to maintain the same release and build numbers on multiple chains/layers while saving gas.
Here, we use it to not upload build 1 of the MultisigSetup again when deploying to polygon.

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik marked this pull request as draft March 22, 2023 15:58
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have chosen a different name than "dummy". Something like UndeployedVersion, VersionPlaceholder, or something when used throws a telling error to the user.

packages/contracts/test/framework/plugin/plugin-repo.ts Outdated Show resolved Hide resolved
@heueristik heueristik marked this pull request as ready for review March 24, 2023 12:50
@heueristik heueristik changed the title Added a dummy plugin setup and test Added a placeholder setups and test Mar 24, 2023
@heueristik heueristik changed the title Added a placeholder setups and test Placeholder setups and Multisig Build 2 deployment Mar 24, 2023
mathewmeconry
mathewmeconry previously approved these changes Mar 24, 2023
@mathewmeconry mathewmeconry merged commit 054f899 into develop Mar 24, 2023
@mathewmeconry mathewmeconry deleted the feature/plugin-setup-dummy branch March 24, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants