Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds missing allowFailureMap parameter to IDAO.Executed event #351

Merged
merged 14 commits into from
Apr 4, 2023
Merged

fix: adds missing allowFailureMap parameter to IDAO.Executed event #351

merged 14 commits into from
Apr 4, 2023

Conversation

mathewmeconry
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

heueristik
heueristik reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions / suggestions

packages/subgraph/src/dao/dao_v1.ts Outdated Show resolved Hide resolved
packages/subgraph/src/dao/dao_v1_2.ts Outdated Show resolved Hide resolved
packages/subgraph/src/dao/dao_v1.ts Outdated Show resolved Hide resolved
heueristik
heueristik previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rekard0
Rekard0 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathewmeconry mathewmeconry merged commit 39ffa73 into develop Apr 4, 2023
@mathewmeconry mathewmeconry deleted the fix/add_allowFailureMap_DAO branch April 4, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@heueristik heueristik heueristik left review comments

Assignees
No one assigned
Labels
contracts subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathewmeconry @Rekard0 @heueristik