Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/os 399 hardhat upgrades #364

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Feature/os 399 hardhat upgrades #364

merged 2 commits into from
Apr 27, 2023

Conversation

heueristik
Copy link
Contributor

@heueristik heueristik commented Apr 27, 2023 •
edited by jira bot
Loading

Description

Bump the hardhat-upgrades packages to the LTS version

Task: OS-399

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@heueristik heueristik requested a review from Rekard0 April 27, 2023 10:13
Rekard0
Rekard0 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heueristik heueristik merged commit b11e4f4 into develop Apr 27, 2023
juliettech13 pushed a commit that referenced this pull request Apr 27, 2023
@heueristik @juliettech13
Feature/os 399 hardhat upgrades (#364)
e4d444a 
* chore: bump hardhat-upgrades version to LTS

* chore: updated deployment checklist
@heueristik heueristik deleted the feature/OS-399-hardhat-upgrades branch April 27, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@josemarinas josemarinas josemarinas approved these changes

@brickpop brickpop Awaiting requested review from brickpop

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heueristik @Rekard0 @josemarinas