Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/ OS-419 export contract source #370

Merged
merged 9 commits into from
May 11, 2023
Merged

F/ OS-419 export contract source #370

merged 9 commits into from
May 11, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented May 9, 2023 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-419

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

brickpop
brickpop reviewed May 9, 2023
View reviewed changes
packages/contracts-versions/README.md Show resolved Hide resolved
packages/contracts-versions/commit_hashes.json Outdated Show resolved Hide resolved
packages/contracts-versions/create-contract-versions.ts Outdated Show resolved Hide resolved
packages/contracts-versions/create-contract-versions.ts Show resolved Hide resolved
packages/contracts/package.json Show resolved Hide resolved
packages/contracts-versions/README.md Outdated Show resolved Hide resolved
packages/contracts-versions/README.md Outdated Show resolved Hide resolved
packages/contracts-versions/README.md Show resolved Hide resolved
packages/contracts-versions/README.md Show resolved Hide resolved
heueristik
heueristik reviewed May 10, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now have clarity on the "missing" versions, do we need to add entries to the contracts/CHANGELOG.md accordingly?

@Rekard0 Rekard0 merged commit 1d956d6 into develop May 11, 2023
@heueristik heueristik deleted the f/OS-419_export_contract_source branch May 11, 2023 08:56
juliettech13 pushed a commit that referenced this pull request May 12, 2023
@Rekard0 @juliettech13
F/ OS-419 export contract source (#370)
31796c9 
* update contract versions

* remove typechain

* update test

* update readme

* add script to contracts package

* clean up

* addressing comments

* update commit hashes

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@heueristik heueristik heueristik approved these changes

@josemarinas josemarinas Awaiting requested review from josemarinas

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rekard0 @brickpop @heueristik