-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typechain and contracts tests #374
Conversation
…ory calls and added missing awaits
d54db73
to
df4a9e3
Compare
10b7c75
to
c1088ef
Compare
packages/contracts/test/plugins/governance/majority-voting/addresslist/addresslist-voting.ts
Show resolved
Hide resolved
packages/contracts/test/plugins/governance/majority-voting/token/token-voting.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments so I approved already to signal that we can merge.
(Since I committed to this branch, my approval will not count anyway)
packages/contracts/deploy/new/20_permissions/10_dao-registry-permissions.ts
Show resolved
Hide resolved
packages/contracts/deploy/new/40_finalize-managing-dao/00_grant-permissions.ts
Outdated
Show resolved
Hide resolved
packages/contracts/deploy/new/40_finalize-managing-dao/30_install-multisig-on-managing-dao.ts
Outdated
Show resolved
Hide resolved
packages/contracts/deploy/new/40_finalize-managing-dao/40_revoke-permissions.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the changes that were made
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: ID
Type of change
Checklist:
CHANGELOG.md
file in the root folder.