-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/ OS-441 test protocol upgrade #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR allow us to create deployment fixtures for specific OSx releases. I would approve this PR but we should merge #384 first.
A general comment:
It remains unclear how we will actually test the protocol upgrades in the future, given that Mathias tests them with tenderly, and that they become irrelevant once the upgrade happened.
I can imagine that these tests are important in the timeframe where we deployed the upgrade on a subset of the supported networks (e.g. the testnets while waiting with the the mainnet deployment). If meanwhile we continue working on the protocol, we want to be sure that the upgrade doesn't break because of this and tests could help in this regard.
Description
Please include a summary of the change and be sure you follow the contributions rules we do provide here
Task: OS-441
Type of change
Checklist:
CHANGELOG.md
file in the root folder.