Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/ OS-441 test protocol upgrade #388

Merged
merged 13 commits into from
May 30, 2023
Merged

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented May 23, 2023

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: OS-441

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR allow us to create deployment fixtures for specific OSx releases. I would approve this PR but we should merge #384 first.

A general comment:
It remains unclear how we will actually test the protocol upgrades in the future, given that Mathias tests them with tenderly, and that they become irrelevant once the upgrade happened.
I can imagine that these tests are important in the timeframe where we deployed the upgrade on a subset of the supported networks (e.g. the testnets while waiting with the the mainnet deployment). If meanwhile we continue working on the protocol, we want to be sure that the upgrade doesn't break because of this and tests could help in this regard.

heueristik
heueristik previously approved these changes May 26, 2023
brickpop
brickpop previously approved these changes May 30, 2023
@Rekard0 Rekard0 dismissed stale reviews from brickpop and heueristik via 8a4941b May 30, 2023 11:04
@Rekard0 Rekard0 merged commit 516b6fd into develop May 30, 2023
@heueristik heueristik deleted the f/OS-441_test-protocol-upgrade branch September 28, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants