Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: corrected build metadata #411

Merged
merged 4 commits into from
Jun 14, 2023
Merged

fix: corrected build metadata #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f7d4bb
fix: corrected build metadata
heueristik Jun 13, 2023
968ef22
fix: added missing item to the change list
heueristik Jun 13, 2023
70ab4a1
feat: updated deployment checklist
heueristik Jun 13, 2023
32c8c2d
feat: improved checklist item
heueristik Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions UPDATE_CHECKLIST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,18 @@ This checklist is seen as a guide to update the existing deployment.
- [ ] Set `ETH_KEY` in `.env` to the deployers private key. It doesn't have to be the previous deployer
- [ ] Set the right API key for the chains blockchain explorer in `.env` (e.g. for mainnet it is `ETHERSCAN_KEY`)
- [ ] Copy the managing DAO multisig env variables from `packages/subgraph/.env-example` into `packages/subgraph/.env`
- [ ] Follow the version specific tasks in the section `Version tasks`
- [ ] Follow the version specific tasks in the section `Version tasks`
- [ ] If new plugin builds are released
- [ ] Double-check that the build-metadata was updated correctly for the UI to work correctly
- [ ] If the plugin is used by the managing DAO and the new build includes security relevant changes it must be applied immediately

## Update

To update run `yarn deploy --network NETWORK` in `packages/contracts` and replace `NETWORK` with the correct network name (e.g. for mainnet it is `yarn deploy --network mainnet`).

## After-Update

- [ ] Follow the version specific tasks in the section `Version tasks`
- [ ] Follow the version specific tasks in the section `Version tasks`

### Configuration updates

Expand Down
6 changes: 1 addition & 5 deletions packages/contracts/src/plugins/governance/multisig/build-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"ui": {},
"change": "- The ability to create a proposal now depends on the membership status of the current instead of the snapshot block.",
"change": "- The ability to create a proposal now depends on the membership status of the current instead of the snapshot block.\n- Added a check ensuring that the initial member list cannot overflow.",
"pluginSetup": {
"prepareInstallation": {
"description": "The information required for the installation.",
Expand Down Expand Up @@ -36,10 +36,6 @@
"1": {
"description": "No input is required for the update.",
"inputs": []
},
"2": {
"description": "No input is required for the update.",
"inputs": []
}
},
"prepareUninstallation": {
Expand Down