add IPFS helper function #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topocount
force-pushed
the
feat/ipfsHelper
branch
from
c1163b1
to
1a408f5
Compare
parses v0 ipfs hashes and returns addresses and strings. Will return a link to the blob if the hash resolves to anything other than a string or and address
topocount
force-pushed
the
feat/ipfsHelper
branch
from
1a408f5
to
55ca5ce
Compare
sembrestels
reviewed
Feb 13, 2020
| import Web3Utils from 'web3-utils' | ||
|
|
||
| // default endpoints to be queried | ||
| const ipfsEndpoints = ['https://ipfs.autark.xyz:5001/api/v0'] |
There was a problem hiding this comment.
I like this feature, but I don't think it is a good practice to hardcode the autark ipfs node here.
There was a problem hiding this comment.
I was using that for my own tests, but Aragon One is welcome to add the api endpoints they maintain. I just left it in because @sohkai usually puts together suggested changes for stuff like this, and this way it passes tests upon submission, since it's an endpoint I have server-side access to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper functions allows v0 CIDs to be queried and the results returned and printed in radspec. If the resulting value is not a string or address, a link is returned to the contents of the hash provided.