Skip to content

Commit

Permalink
change .initAttrs agrument #40
Browse files Browse the repository at this point in the history
  • Loading branch information
popomore committed May 8, 2013
1 parent f8f33a8 commit 0f4cae7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"alias": {
"$": "$",
"handlebars": "gallery/handlebars/1.0.1/handlebars",
"base": "arale/base/1.0.1/base"
"base": "arale/base/1.1.0/base"
},
"output": ["widget.js", "templatable.js"]
}
Expand Down
2 changes: 1 addition & 1 deletion src/widget.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ define(function(require, exports, module) {

// 初始化 attrs
var dataAttrsConfig = this._parseDataAttrsConfig(config)
this.initAttrs(config, dataAttrsConfig)
this.initAttrs(config ? $.extend(dataAttrsConfig, config) : dataAttrsConfig)

// 初始化 props
this.parseElement()
Expand Down
3 changes: 2 additions & 1 deletion tests/widget-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,8 @@ define(function(require) {
expect(t.get('arr')).to.eql([1, 2, 3])
})

it('onXx setter in attrs', function() {
// base 1.1.0 不再支持这种写法
xit('onXx setter in attrs', function() {
var counter = 0

function incr() {
Expand Down

0 comments on commit 0f4cae7

Please sign in to comment.