fix(utils): Load typescript files relative to process current working directory #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lluiscab
changed the title
4 tasks
aralroca
approved these changes
Apr 29, 2024
|
@lluiscab currently available in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
I've been having problems with this plugin due to the folder structure of my project and
NEXT_TRANSLATE_PATHnot being respected byts.createProgram(). This change makes sure that the typescriptProgramcreated can access the source files correctly and does not returnundefined.It might also be a good idea to throw an error/warning if
program.getSourceFile()returns undefined, altering the user of the issue. I've been trying to track down the cause of an issue similar to aralroca/next-translate#1040 (different root cause) and it's been a nightmare trying to debug it without having any information available on whatever or not the plugin was working correctly.I'd recommend merging #78 first