Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible translate interface #483

Closed
gurkerl83 opened this issue Jan 31, 2021 · 0 comments · Fixed by #485
Closed

Incompatible translate interface #483

gurkerl83 opened this issue Jan 31, 2021 · 0 comments · Fixed by #485
Milestone
1.0.3

Comments

@gurkerl83
Copy link
Contributor

In the following commit #470 a refactoring of the translate interface was introduced. In the commit message those changes were described to simplify the function, but in the end it makes using generics impossible.

Basically those changes makes it impossible to do things described in
#367 (comment)
#377
@aralroca aralroca added this to the 1.0.3 milestone Feb 1, 2021
gurkerl83 pushed a commit to project-millipede/next-translate that referenced this issue Feb 1, 2021
Allow passing a generic type to the translate fn
b4ca6fb 
Resolves aralroca#483
@gurkerl83 gurkerl83 mentioned this issue Feb 1, 2021
Merged
aralroca pushed a commit that referenced this issue Feb 1, 2021
@gurkerl83
Allow passing a generic type to the translate fn (#485)
24e968d 
Resolves #483

Co-authored-by: gurkerl83 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

Allow passing a generic type to the translate fn project-millipede/next-translate
2 participants
@gurkerl83 @aralroca