Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getStaticPaths, getStaticProps, getServerSideProps + fix examples #68

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Allow getStaticPaths, getStaticProps, getServerSideProps + fix examples #68

merged 1 commit into from
Mar 9, 2020

Conversation

aralroca
Copy link
Owner

@aralroca aralroca commented Mar 9, 2020

Fixes #67

@aralroca aralroca self-assigned this Mar 9, 2020
@aralroca aralroca merged commit 9be9e81 into master Mar 9, 2020
@BjoernRave
Copy link
Contributor

I am not 100% sure it is becuase of next-translate, but have you actually tested using it with getServerSideProps ? Because for me it doesn't seem to work

@aralroca
Copy link
Owner Author

It's for next-translate, I can confirm. I misunderstood the way to use it. I explain it here: #75

Thanks a lot to report it. 👍

@aralroca aralroca deleted the aral-allow-more-methods-and-fix-examples branch March 12, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aralroca aralroca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI] Fix getStaticProps, getServerSideProps and getStaticPaths old build time
2 participants
@aralroca @BjoernRave