Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript anotation #70

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix typescript anotation #70

merged 1 commit into from
Mar 11, 2020

Conversation

aralroca
Copy link
Owner

Fixes #41

@aralroca aralroca self-assigned this Mar 11, 2020
@aralroca aralroca merged commit 8c04e53 into master Mar 11, 2020
@aralroca aralroca deleted the fix-typescript-anotation branch March 11, 2020 18:05
@BjoernRave
Copy link
Contributor

it doesn't work like that

SyntaxError: /Users/bjoern/projects/inventhora/frontend/pages/es/partner/[id]/index.tsx: Unexpected token, expected "," (9:31)

   7 | const namespaces = { 'common': ns0, 'table': ns1 }
   8 | 
>  9 | export default function Page(p as any){
     |                                ^
  10 |   return (
  11 |     <I18nProvider lang="es" namespaces={namespaces} >
  12 |       <C {...p} />

it should be like this:

SyntaxError: /Users/bjoern/projects/inventhora/frontend/pages/es/partner/[id]/index.tsx: Unexpected token, expected "," (9:31)

   7 | const namespaces = { 'common': ns0, 'table': ns1 }
   8 | 
>  9 | export default function Page(p: any){
     |                                ^
  10 |   return (
  11 |     <I18nProvider lang="es" namespaces={namespaces} >
  12 |       <C {...p} />

@aralroca
Copy link
Owner Author

Thanks! Your PR is already merged! Also would be great to add tests of this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tsx files
2 participants