Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when Router options is undefined #86

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

justincy
Copy link
Contributor

You can verify the problem by running the test without the fix. It will cause an error. Existing tests didn't catch it because they way they are written, options will always be defined.

Feel free to change the test to match your style. I mostly added it to prove that there was a problem that needed to be fixed.

@aralroca
Copy link
Owner

Ok, nice catch!

@aralroca aralroca merged commit ea90b5b into aralroca:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants